Ovid

Thanks for the work. I looked at your dist.ini and it makes a good start. A friend and I are looking at becoming owners to a rather largest module and might go the Dist::Zilla route with it.

Hi Ovid,

Just a quick note for your "Zen of Test Suites" particularly this bit:

https://github.com/Ovid/zen-of-test-suites#much-of-the-testing-code-is-duplicated

I've found that putting repetitive and declarative test data into arrays makes it easier to figure out which of the items failed its tests. Especially at first glance, before you realize it's a hash and the order is not guaranteed.

So something like:

my @id_tests = (
    { id => $id,
      tests => [
        [ attr1 => $expected1 ],
        [ attr2 => $expected2 ],
        [ attr3 => $expected3 ],
        [ attr4 => $expected4 ],
        [ attr5 => $expected5 ],
    ]},
    { id => $new_id,
      tests  => [
        [ attr1 => $new_expected1 ],
        [ attr2 => $new_expected2 ],
        [ attr3 => $new_expected3 ],
        [ attr4 => $new_expected4 ],
        [ attr5 => $new_expected5 ],
    ]},
);

for my $test ( @id_tests ){
      test_fetching_by_id( 'Object', $test->{id}, $tests->{test} );
}

If that adds too much syntactical overhead I would at the very least update the final test executed to include the $id so that you can figure out which object failed the test:

is $object->$attribute, $expected, "$attribute works for $class $id";